Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

doc: mark querystring api as legacy #38436

Closed
wants to merge 1 commit into from
Closed

doc: mark querystring api as legacy #38436

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 27, 2021

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #38231

@jasnell
doc: mark querystring api as legacy
28b0de8 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#38231
@github-actions github-actions bot added doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module. labels Apr 27, 2021
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 27, 2021
@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2021

Simple change that shouldn't need to wait the 48 hours to land. Fast-track? Please 👍🏻

panva pushed a commit that referenced this pull request Apr 29, 2021
@jasnell @panva
doc: mark querystring api as legacy
32ade69 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@panva
Copy link
Member

panva commented Apr 29, 2021

Landed in 32ade69

@panva panva closed this Apr 29, 2021
@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
@jasnell @targos
doc: mark querystring api as legacy
3cbfde1 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@jasnell @targos
doc: mark querystring api as legacy
6334898 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
@jasnell @targos
doc: mark querystring api as legacy
9c9f31a 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
@jasnell @targos
doc: mark querystring api as legacy
6faa1fa 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@jasnell @targos
doc: mark querystring api as legacy
839e8d1 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate the old querystring in favor of URLSearchParams?
6 participants
@jasnell @panva @addaleax @targos @richardlau @aduh95